General stuff #298
General stuff #298
Conversation
Signed-off-by: Suki <suki@missallsunday.com>
without having to use loadMemberContext() Signed-off-by: Suki <suki@missallsunday.com>
Signed-off-by: Suki <suki@missallsunday.com>
…st... Signed-off-by: Suki <suki@missallsunday.com>
Signed-off-by: Suki <suki@missallsunday.com>
|
OK, for the loadMemberCustomFields($users) function makes any sense it gotta have an extra param, a title param to get specific rows and not the entire themes table... or better yet, an array or titles to be able to get multiple profile fields at once. I'll get to that later, kudos goes to Oldiesmann for letting me know about this on IRC. |
Signed-off-by: Suki <suki@missallsunday.com>
|
OK MissAllSunday@e2bf6e0 sets a better and cleaner version. It nows pass all possible variables for each field and supports multiple field names as well as multiple users. |
Signed-off-by: Suki <suki@missallsunday.com>
| FROM {db_prefix}themes AS t | ||
| LEFT JOIN {db_prefix}custom_fields AS c ON (c.col_name = t.variable) | ||
| WHERE id_member' . (count($users) == 1 ? ' = {int:loaded_ids} ' : ' IN ({array_int:loaded_ids}) ') . | ||
| 'AND variable' . (count($params) == 1 ? ' = {string:params}' : ' IN ({array_string:params})'), |
There was a problem hiding this comment.
Why not use just IN?
That would save you some comparisons:
WHERE id_member IN ({array_int:loaded_ids})
AND variable IN ({array_string:params})',
and here below:
'loaded_ids' => $users,
'params' => $params,
There was a problem hiding this comment.
Because thats how SMF do things... I just followed and copy/paste SMF coding style.
There was a problem hiding this comment.
Okay...never checked before... 👼
/me feels is a bit odd
I'm not sure if there is any practical difference...
There was a problem hiding this comment.
There isn't if you aren't picky in terms of performance, it is if you want the code to be more organized but there is a bazillion other places where SMF does this, might as well go with the flow.
There was a problem hiding this comment.
SMF avoids using 'IN' in the query, for the query to use the index instead. There's only an index on id_member iirc however.
There was a problem hiding this comment.
From my (quick) test with EXPLAIN, MySQL is smart enough to understand there is just one value and uses the index anyway. Of course if there is more than one then it doesn't.
There was a problem hiding this comment.
Cool, thanks for checking it out!
Just some general stuff: